-
Notifications
You must be signed in to change notification settings - Fork 337
Fixed issue with tail not deserailzing event properly #1994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really good change :) one comment and a few nits, and then I think it's ready to go.
Depends on chrome-devtools-rs#51 getting merged and released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caass -- this would be good to get into the upcoming release. Mind taking a final pass on it and ✅ ?
oops, missed the failing test. @jspspike, would you be able to format this ( |
The tests are failing on this because it's using things I've added to |
@jspspike hah, that will teach me to read the rest of the comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do we now need to publish a new version of chrome-devtools-rs
? Other than that, we're pretty much good, right?
Also added color to
wrangler dev
andwrangler tail -f pretty
json outputs if deserialized properlyFixes #1990